Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 0 early if divisor is 0 - U128 div #6652

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

SwayStar123
Copy link
Member

Description

Incase panic on unsafe math is disabled, we return 0 if divisor is 0

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@SwayStar123 SwayStar123 self-assigned this Oct 17, 2024
@SwayStar123 SwayStar123 added bug Something isn't working lib: std Standard library labels Oct 17, 2024
@SwayStar123 SwayStar123 marked this pull request as ready for review October 17, 2024 05:46
@SwayStar123 SwayStar123 requested review from a team as code owners October 17, 2024 05:46
@K1-R1 K1-R1 merged commit e6059a5 into master Oct 17, 2024
38 checks passed
@K1-R1 K1-R1 deleted the swaystar/early-return-div-by-0-u128 branch October 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lib: std Standard library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants