Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace module cleanups #6660

Merged
merged 15 commits into from
Oct 24, 2024
Merged

Conversation

tritao
Copy link
Contributor

@tritao tritao commented Oct 21, 2024

Description

This PR represents another round of cleanups, this time mostly around Namespace and Root.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@tritao tritao added the compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen label Oct 21, 2024
@tritao tritao self-assigned this Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #6660 will improve performances by 10.04%

Comparing tritao:namespace-module-cleanups (ff9dd31) with master (d6b9def)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark master tritao:namespace-module-cleanups Change
document_symbol 5.2 ms 4.7 ms +10.04%

@tritao tritao force-pushed the namespace-module-cleanups branch 5 times, most recently from 52799e0 to c867f57 Compare October 21, 2024 19:48
@tritao tritao marked this pull request as ready for review October 22, 2024 10:06
@tritao tritao requested a review from a team as a code owner October 22, 2024 10:06
@tritao tritao requested a review from jjcnn October 22, 2024 10:06
Copy link
Contributor

@jjcnn jjcnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the changes to type_resolve.rs, but I would really like if the code in namespace.rs and root.rs wasn't moved around too much. I'm making a lot of changes in those files, so it's super complicated to keep track of my changes when code is moved to somewhere else.

sway-core/src/semantic_analysis/namespace/module.rs Outdated Show resolved Hide resolved
sway-core/src/semantic_analysis/namespace/module.rs Outdated Show resolved Hide resolved
@tritao
Copy link
Contributor Author

tritao commented Oct 23, 2024

Updated the PR, I've removed most of the bigger changes to Namespace and Root now, we can re-access if they are still needed once the dust settles.

@tritao tritao requested a review from IGI-111 October 23, 2024 11:15
@tritao tritao merged commit be70774 into FuelLabs:master Oct 24, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler: frontend Everything to do with type checking, control flow analysis, and everything between parsing and IRgen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants