-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace module cleanups #6660
Conversation
CodSpeed Performance ReportMerging #6660 will improve performances by 10.04%Comparing Summary
Benchmarks breakdown
|
52799e0
to
c867f57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the changes to type_resolve.rs
, but I would really like if the code in namespace.rs
and root.rs
wasn't moved around too much. I'm making a lot of changes in those files, so it's super complicated to keep track of my changes when code is moved to somewhere else.
c867f57
to
12fe4d7
Compare
12fe4d7
to
d7e6921
Compare
Updated the PR, I've removed most of the bigger changes to |
Description
This PR represents another round of cleanups, this time mostly around
Namespace
andRoot
.Checklist
Breaking*
orNew Feature
labels where relevant.