Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rust version to 1.82 #6672

Merged
merged 7 commits into from
Oct 28, 2024
Merged

chore: bump rust version to 1.82 #6672

merged 7 commits into from
Oct 28, 2024

Conversation

kayagokalp
Copy link
Member

Description

Bumps sway version used in CI to v1.82

Copy link

codspeed-hq bot commented Oct 24, 2024

CodSpeed Performance Report

Merging #6672 will not alter performance

Comparing kayagokalp/rust-1.82 (6247aa3) with master (7e499fe)

Summary

✅ 22 untouched benchmarks

@kayagokalp
Copy link
Member Author

kayagokalp commented Oct 24, 2024

We have couple of warnings around using keys with interior mutability.

This is bad because ideally HashMap key shouldn't be changing so that's why we have the lint in place.

But the lint has known false positives for types that has interior mutability but doesn't access that interior mutable type for its Hash or Ord implementation.

We need to check whether it is the case for our case and if that is the case we should deny the warning.

https://rust-lang.github.io/rust-clippy/master/index.html#mutable_key_type

cc @FuelLabs/sway-compiler

@kayagokalp kayagokalp marked this pull request as ready for review October 27, 2024 19:39
@kayagokalp kayagokalp requested review from a team as code owners October 27, 2024 19:39
@JoshuaBatty JoshuaBatty requested review from a team October 27, 2024 22:50
@alfiedotwtf
Copy link
Contributor

alfiedotwtf commented Oct 27, 2024

We have couple of warnings around using keys with interior mutability.

When I originally did #6501 I ran into this and had 99% of the changes done for the interior mutability warnings, but those were dropped when other priorities came around. I'll put it on my list as something to do for a background task.

@IGI-111 IGI-111 merged commit 4efd248 into master Oct 28, 2024
40 checks passed
@IGI-111 IGI-111 deleted the kayagokalp/rust-1.82 branch October 28, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants