-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transmute intrinsics #6692
Merged
Merged
Transmute intrinsics #6692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunilrj
force-pushed
the
xunilrj/transmute-intrinsics
branch
from
November 4, 2024 22:39
50afe41
to
73a4be0
Compare
CodSpeed Performance ReportMerging #6692 will not alter performanceComparing Summary
|
xunilrj
force-pushed
the
xunilrj/transmute-intrinsics
branch
3 times, most recently
from
November 12, 2024 09:24
386909e
to
6c83607
Compare
xunilrj
force-pushed
the
xunilrj/transmute-intrinsics
branch
from
November 13, 2024 19:35
a49593b
to
50e70b1
Compare
IGI-111
approved these changes
Nov 14, 2024
vaivaswatha
approved these changes
Nov 14, 2024
tritao
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
__transmute
intrinsic. As Rust this intrinsic should be a no-op semantically equal to a pointer cast. Although this PR does not aim that it is 100% no-op yet.At the moment some trade-offs were taken:
1 - References, pointers etc... are not allowed at the moment;
2 -
u16
andu32
actually occupy 64bits. To allow transmute to work in complex aggregates, this PR is accepting them asu64
. Doing otherwise would forbid__transmute
to be no-op. Specially in complex aggregates;Checklist
Breaking*
orNew Feature
labels where relevant.