Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test encoding raw slices does not allows buffer overflows #6699

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

xunilrj
Copy link
Contributor

@xunilrj xunilrj commented Nov 6, 2024

Description

Test for #6686 buffer overflow on Bytes encoding. This test fails without the fix and pass with it.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@xunilrj xunilrj requested review from a team as code owners November 6, 2024 10:37
@xunilrj xunilrj self-assigned this Nov 6, 2024
@xunilrj xunilrj changed the title Test encoding raw slices does not have buffer overflow Test encoding raw slices does not allows buffer overflows Nov 6, 2024
@xunilrj xunilrj force-pushed the xunilrj/better-test-encoding-raw-slice branch from a8aaae3 to f520f50 Compare November 12, 2024 11:40
@IGI-111 IGI-111 requested a review from a team November 12, 2024 11:42
@xunilrj xunilrj merged commit 861ca10 into master Nov 13, 2024
39 checks passed
@xunilrj xunilrj deleted the xunilrj/better-test-encoding-raw-slice branch November 13, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants