Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests of visibility of private direct submodules #6849

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add tests of visibility of private direct submodules #6849

wants to merge 7 commits into from

Conversation

jjcnn
Copy link
Contributor

@jjcnn jjcnn commented Jan 21, 2025 •
edited
Loading

Description

#5765 was solved by an earlier PR, but we don't seem to have regression tests for that situation. This PR adds those tests.

Checklist

  • I have linked to any relevant issues.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation where relevant (API docs, the reference, and the Sway book).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added (or requested a maintainer to add) the necessary Breaking* or New Feature labels where relevant.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@jjcnn jjcnn requested a review from a team as a code owner January 21, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdankel sdankel sdankel approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjcnn @sdankel