Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ec_recover test to use updated B512 data structure. #725

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

otrho
Copy link
Contributor

@otrho otrho commented Jan 31, 2022

This is a small change to accommodate the (proposed) changes to B512 and ec_recover() in sway-lib-std.

@otrho otrho added lib: std Standard library testing General testing labels Jan 31, 2022
@otrho otrho requested review from sezna and nfurfaro January 31, 2022 06:01
@otrho otrho self-assigned this Jan 31, 2022
@@ -6,4 +6,4 @@ entry = "main.sw"

[dependencies]
core = { git = "http://github.com/FuelLabs/sway-lib-core", version = "v0.0.1" }
std = { git = "http://github.com/FuelLabs/sway-lib-std", version = "v0.0.1" }
std = { git = "http://github.com/FuelLabs/sway-lib-std", version = "v0.0.2" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to pin whichever version has the new B512 code.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good. I will see about tagging and releasing a new version of std today.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.1.0 of the stdlib has been released if you want to pin this.

nfurfaro
nfurfaro previously approved these changes Feb 2, 2022
Copy link
Contributor

@nfurfaro nfurfaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otrho otrho force-pushed the otrho/update_ec_recover_test branch from f29eeb6 to 6d94a21 Compare February 3, 2022 02:14
@otrho otrho marked this pull request as ready for review February 3, 2022 02:14
@otrho otrho merged commit 68f8342 into master Feb 3, 2022
@otrho otrho deleted the otrho/update_ec_recover_test branch February 3, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib: std Standard library testing General testing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants