Fix E2E tests for IR. #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It previously didn't bother to special-case `B256` literals, and initialised only the first word, using `SW`. We now use `MCPI` and produce identical code as the original codegen.
They can be `TypedVariableDeclaration`s as well as `TypedConstantDeclaration`s now, but to distinguish between var decls which were originally const decls or not a new marker `const_decl_origin` has been added to `TypedVariableDeclaration`.
We don't have an efficient way to check if a value has zero uses and is safe to remove, so until then, unless we're very careful, removing values should be avoided.
After 8fe74e0 we let `TypeInfo::Numeric` stay in the AST post-typecheck, so we need to support them in IR generation.
…viously disabled tests.
…roneous recursive calls. This edge case will go away when we stop inlining calls in the AST.
adlerjohn
added
the
compiler
sezna
reviewed
Feb 2, 2022
| ("aliased_imports", ProgramState::Return(42)), | ||
| ("empty_method_initializer", ProgramState::Return(1)), // true | ||
| ("b512_struct_alignment", ProgramState::Return(1)), // true | ||
| ("generic_structs", ProgramState::Return(1)), // true | ||
| ("generic_functions", ProgramState::Return(1)), // true | ||
| ("generic_enum", ProgramState::Return(1)), // true | ||
| ("import_method_from_other_file", ProgramState::Return(10)), // true | ||
| ("b512_test", ProgramState::Return(1)), // true |
There was a problem hiding this comment.
would you rather comment these out instead of deleting them so they aren't forgotten?
There was a problem hiding this comment.
They were all duplicates. This is what prompted me to create #723
|
A new version of |
sezna
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some relatively minor fixes for bugs which accrued while I was away. The E2E tests were failing sometimes when using IR, these changes fix that.
The
ec_recover_teststill fails with IR but will be resolved when the newB512code insway-lib-stdis released.Closes #709