-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing a generic types resolution bug #736
Merged
sezna
merged 11 commits into
FuelLabs:master
from
mohammadfawaz:generic_types_resolution_bug
Feb 6, 2022
Merged
Fixing a generic types resolution bug #736
sezna
merged 11 commits into
FuelLabs:master
from
mohammadfawaz:generic_types_resolution_bug
Feb 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadfawaz
changed the title
Generic types resolution bug
Fixing a generic types resolution bug
Feb 2, 2022
mohammadfawaz
added
compiler
General compiler. Should eventually become more specific as the issue is triaged
bug
Something isn't working
labels
Feb 2, 2022
sezna
suggested changes
Feb 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- one nit
sezna
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #716
Basically, I'm calling
monomorphize()
when resolving a generic type so that the original type doesn't get modified. Also copying the methods of the original type to the new type.