Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Importing the same item multiple times should be a compile error #739

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Importing the same item multiple times should be a compile error #739

merged 3 commits into from
Feb 3, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Feb 3, 2022 •
edited
Loading

Closes #727

This is important because one can currently write:

use ::bar::Bar1 as Bar2;
use ::bar::Bar2;

but that, of course, is confusing.

@mohammadfawaz mohammadfawaz requested a review from sezna as a code owner February 3, 2022 19:39
@mohammadfawaz mohammadfawaz self-assigned this Feb 3, 2022
@mohammadfawaz mohammadfawaz added compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request labels Feb 3, 2022
sezna
sezna previously approved these changes Feb 3, 2022
View reviewed changes
@mohammadfawaz mohammadfawaz merged commit f862bf3 into FuelLabs:master Feb 3, 2022
@mohammadfawaz mohammadfawaz deleted the importing_the_same_item_twice_error branch February 3, 2022 20:45
@mohammadfawaz mohammadfawaz mentioned this pull request Feb 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

Assignees

@mohammadfawaz mohammadfawaz

Labels
compiler General compiler. Should eventually become more specific as the issue is triaged enhancement New feature or request
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing the same item multiple times should be a compile error
2 participants
@mohammadfawaz @sezna