Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrange forc.toml fields alphabetically #754

Merged
merged 2 commits into from
Feb 8, 2022
Merged

Arrange forc.toml fields alphabetically #754

merged 2 commits into from
Feb 8, 2022

Conversation

eureka-cpu
Copy link
Contributor

closes #724 by arranging forc.toml fields alphabetically

@eureka-cpu eureka-cpu requested review from adlerjohn and sezna February 8, 2022 00:25
@eureka-cpu eureka-cpu self-assigned this Feb 8, 2022
@eureka-cpu eureka-cpu changed the title forc.toml fields aren't arranged alphabetically arrange forc.toml fields alphabetically Feb 8, 2022
@eureka-cpu eureka-cpu changed the title arrange forc.toml fields alphabetically Arrange forc.toml fields alphabetically Feb 8, 2022
adlerjohn
adlerjohn suggested changes Feb 8, 2022
View reviewed changes
forc/src/utils/defaults.rs Outdated Show resolved Hide resolved
forc/src/utils/defaults.rs Outdated Show resolved Hide resolved
@eureka-cpu eureka-cpu requested a review from adlerjohn February 8, 2022 17:33
adlerjohn
adlerjohn reviewed Feb 8, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, but will defer to @sezna

@eureka-cpu eureka-cpu merged commit 9cdba5c into master Feb 8, 2022
@eureka-cpu eureka-cpu deleted the eureka-cpu/forc-toml-default-fmt branch February 8, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sezna sezna sezna approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

Assignees

@eureka-cpu eureka-cpu

Labels
forc formatter
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Forc.toml created by forc init isn't properly formatted
3 participants
@eureka-cpu @adlerjohn @sezna