Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turning an instance of HashSet into BTreeSet in asm_generation #759

Merged
merged 2 commits into from
Feb 8, 2022

Conversation

mohammadfawaz
Copy link
Contributor

@mohammadfawaz mohammadfawaz commented Feb 8, 2022

Closes #619

At the very least, John's minimum repro doesn't have indeterminsm anymore, so this change should go in anyways. I'm checking if it fixes the main issue next.

Edit: Confirmed that @nfurfaro's original issue is resolved with this.

@mohammadfawaz mohammadfawaz requested a review from sezna as a code owner February 8, 2022 21:38
@mohammadfawaz mohammadfawaz self-assigned this Feb 8, 2022
@mohammadfawaz mohammadfawaz added compiler General compiler. Should eventually become more specific as the issue is triaged bug Something isn't working labels Feb 8, 2022
Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@sezna sezna merged commit 9100b88 into FuelLabs:master Feb 8, 2022
@mohammadfawaz mohammadfawaz deleted the non-deterministic-asm branch February 9, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-deterministic contract IDs
2 participants