fix: fix formatter adding -- to multiple use statements
#773
Conversation
|
Inadvertently stashed my test… For the rename, it's because of a weird formatter bug, I'm going to explicit it |
There was a problem hiding this comment.
This should be solved where the problem is (in handling of the UseStatement),
this current approach could even cause a bug if there are two lines that are the same, it would filter them as well.
Plus not sure why renaming that struct in a test is needed or connected to any of this?
Suggested solution:
in traverse_ast_node() where UseStatement is handled
if next_line of code is a UseStatement,
and if there already exists in changes the last_item.start that equals to next_line.start,
then they are the same UseStatement - so no need to handle it again, just ignore it.
* the renaming of the example struct `Lighthouse` and `Dart` is to have two different blocks of code. Otherwise the two code blocks are exactly identical (incl. comment) and the formatter adds an extra newline.
|
Ok, implementing the suggested solution. It turns out that the "struct" renaming was indeed linked to 2 blocks of code being identical and a newline appearing because of it. |
What were the odds lol |
iqdecay
dismissed stale reviews from digorithm, adlerjohn, and leviathanbeak
via
fe5016c
|
I updated the "Temporary workaround" section about formatting, because, as shown by fe5016c, we actually do format non-compiling code. |
This PR fixes #684