Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forc: Add util user_forc_directory function #809

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

mitchmindtree
Copy link
Contributor

This changes the forc explorer tool from using .fuel as its user
directory to follow suit of forc's dependency handling and use .forc
instead.

Path handling for both has also been fixed to theoretically better
support windows (though I haven't tested).

Both are now implemented in terms of the new user_forc_directory
function.

Closes #778.

This changes the `forc explorer` tool from using `.fuel` as its user
directory to follow suit of `forc`'s dependency handling and use `.forc`
instead.

Path handling for both has also been fixed to theoretically better
support windows (though I haven't tested).

Both are now implemented in terms of the new `user_forc_directory`
function.

Closes #778.
@mitchmindtree mitchmindtree force-pushed the mitchmindtree/forc-home branch 2 times, most recently from a617904 to 36417fb Compare February 18, 2022 02:12
Also refactors `forc_update` and `forc::utils::dependency` in terms of
the updated `user_forc_directory` function.
@mitchmindtree mitchmindtree force-pushed the mitchmindtree/forc-home branch from 36417fb to ddea7e2 Compare February 18, 2022 02:17
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but seems fine to me.

Copy link
Contributor

@alex-matthe alex-matthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The explorer paths struct looks cleaner now

@mitchmindtree mitchmindtree merged commit 323b4e1 into master Feb 20, 2022
@mitchmindtree mitchmindtree deleted the mitchmindtree/forc-home branch February 20, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Compute Forc home directory in only one place
3 participants