Remove the unused &mut dependency_graph throughout sway-core
#826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on #825 I noticed that that the `dependency_graph` is unused throughout `sway-core`. I think the reason why cargo doesn't emit any warnings about this is that at one point, it's stored in the public `TypeCheckArgument` struct, so cargo believes that it is intentionally being re-exported, however in reality we don't use it anywhere else in the fuel/sway/forc ecosystem.
otrho
suggested changes
Feb 22, 2022
Oh, you changed the file mode. |
otrho
approved these changes
Feb 22, 2022
14 tasks
mitchmindtree
added
the
compiler
emilyaherbert
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #825 I noticed that that the
dependency_graphisunused throughout
sway-core. I think the reason why cargo doesn't emitany warnings about this is that at one point, it was stored in the public
TypeCheckArgumentstruct, so cargo believes that it is intentionallybeing re-exported, however in reality we don't use it anywhere else in
the fuel/sway/forc ecosystem.
Edit: Oh also, It's not clear in the diff, but the
source_map.rsfile change just removes executable permissions from the file so that the file permissions match the rest of the src. I noticed it had executable permissions for some reason, but I'm quite certain that trying to run./sway/sway-core/src/source_map.rsdirectly won't do anything interesting 😂