Smaller IR changes. #828
Merged
Smaller IR changes. #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I put it there initially without thinking, and then just used the name 'script' for scripts, etc. This just removes it altogether; touches a lot of the test files.
The IR doesn't care about struct field names nor enum variant names. They need to be tracked by IRgen though, so instead of managing it in the IR Context it can be all done in IRgen core.
otrho
added
enhancement
|
These are not meant to be user-facing errors right? I'm assuming these are strictly syntax errors for the IR language that can be triggered if someone writes bad IR by hand or introduce a transform pass that outputs bad IR. |
emilyaherbert
approved these changes
Feb 23, 2022
Correct. Hard to tell the user that 'phi instructions must have unique labels' and expect them to fix it. 🙂 |
mohammadfawaz
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IrError, which at the moment is pretty small and simple, will grow in time.Result<T, IrError>now.script script { ... }in the tests.sway-core. The IR doesn't have named fields for structs or enums but for convenience I originally put the symbol table needed during compilation into the IR context. It's only needed bysway-core/src/optimize.rsso that's where it now lives.Closes #647.