Use Clap V3 instead of StructOpt #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchmindtree
approved these changes
Feb 28, 2022
| @@ -2869,7 +2914,7 @@ version = "0.3.26" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "0c6b5c64445ba8094a6ab0c3cd2ad323e07171012d9c98b0b15651daf1787a10" | |||
| dependencies = [ | |||
| "clap", | |||
| "clap 2.34.0", | |||
There was a problem hiding this comment.
We should track down whatever's using this in the other fuel repos and update those crates to also use clap 3 to avoid dependency bloat, but it's probably fine to do this in a follow-up PR.
There was a problem hiding this comment.
Cool, looks like the fuel-gql-client repo is still relying on structopt. I'll make a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StructOptis now in maintenance mode and has been integrated intoclapv0.3.By using
clapinstead ofStructOptwe can also take advantage ofclap_completewhich enables shell autocompletion.