Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding an unnecessary move from the body(ies) of an if/else block #894

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

mohammadfawaz
Copy link
Contributor

Closes #892

The existing behavior impacts the liveness analysis phase of the register allocator and make it seem like the problematic register is alive since the start of the program.

@mohammadfawaz mohammadfawaz self-assigned this Mar 7, 2022
@mohammadfawaz mohammadfawaz added bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged labels Mar 7, 2022
Copy link
Contributor

@emilyaherbert emilyaherbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mohammadfawaz mohammadfawaz merged commit 7109b98 into master Mar 7, 2022
@mohammadfawaz mohammadfawaz deleted the mohammadfawaz/892 branch March 7, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compiler General compiler. Should eventually become more specific as the issue is triaged
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

If/else expressions that don't get assigned lead to used-but-not-defined virtual registers.
2 participants