-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add docs for autocompletions and forc init template #899
Conversation
Up to you. I think images are fine so long as it's not overdone. |
I've created a new |
Media is fine. Does it actually get compiled properly with mdbook? |
Good call, just built the book locally and it doesn't seem to copy the file into the book when it's built. Seems like it only works if the gif link is a URL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably shouldn't rely on a remote source for images IMO. If we can't include it locally then better to not include it at all.
Yep, fair enough. I'll remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the actual file too? docs/media/forc_auto_complete.gif
looks like it's still there
Question, @adlerjohn do we want to embed the autocompletions gif at the end of that section? Or would we prefer to keep the sway book text only?