Move forc's util and pkg related code into forc-util, forc-pkg
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a start on #863 by refactoring the "package" handling code into a `forc-pkg` crate. This new crate is solely responsible for building, fetching, locking and updating of forc packages. `forc-pkg` pulls in around 170 dependencies altogether, as opposed to `forc`'s current ~460. This should be useful for downstream crates that may want to depend on `forc` without all the bloat of the CLI tooling, explorer, etc. The `sway-lsp` crate comes to mind. To achieve this, some of forc's utility functionality has been moved into `forc-util` so that it may be shared between `forc-pkg` and `forc` itself.
adlerjohn
reviewed
Mar 8, 2022
Also tweaks the version declarations for forc-pkg dependencies.
adlerjohn
suggested changes
Mar 8, 2022
adlerjohn
reviewed
Mar 8, 2022
adlerjohn
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
lgtm, but I will defer to @sezna or @JoshuaBatty for a second set of eyes
JoshuaBatty
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a start on #863 by refactoring the "package" handling code
into a
forc-pkgcrate. This new crate is solely responsible forbuilding, fetching, locking and updating of forc packages.
forc-pkgpulls in around 170 dependencies altogether, as opposed toforc's current ~460. This should be useful for downstream crates thatmay want to depend on
forcwithout all the bloat of the CLI tooling,explorer, etc. The
sway-lspcrate comes to mind.To achieve this, some of forc's utility functionality has been moved
into
forc-utilso that it may be shared betweenforc-pkgandforcitself.