removes forc clean cargo toml error #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Produces an error rather than panicking when the user specifies a semver version which is currently unsupported. As mentioned at: #918 (comment)
adlerjohn
suggested changes
Mar 15, 2022
There was a problem hiding this comment.
This should definitely be changed! Instead of removing (which would be better than simply commenting out), cargo clean should not be ran at all if Cargo.toml doesn't exist. The reason being that there might be other ways cargo clean can fail, and we shouldn't silence those errors.
Thank you for clarifying! I'll get on this tomorrow morning. (commented out since I wasn't sure btw) |
adlerjohn
reviewed
Mar 15, 2022
mitchmindtree
suggested changes
Mar 16, 2022
This was referenced Mar 16, 2022
mitchmindtree
suggested changes
Mar 16, 2022
mitchmindtree
approved these changes
Mar 16, 2022
adlerjohn
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #932
I've updated the
find_manifest_dirfunction to be dynamic, so that we can find either aForc.tomlorCargo.toml, then used that function to check for aCargo.tomland if one is not found, emit a non-error warning message that without onecargo cleanwill be bypassed.