Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and docs for while loops #960

Merged
merged 10 commits into from
Mar 18, 2022
Merged

Add tests and docs for while loops #960

merged 10 commits into from
Mar 18, 2022

Conversation

nfurfaro
Copy link
Contributor

All in the title.

  • adds a new e2e test in the sway repo.
  • adds a new Control Flow section in the sway book.

closes #749

@nfurfaro nfurfaro added documentation testing General testing labels Mar 17, 2022
@nfurfaro nfurfaro self-assigned this Mar 17, 2022
@nfurfaro nfurfaro requested review from mohammadfawaz and removed request for mohammadfawaz March 17, 2022 21:04
@nfurfaro
Copy link
Contributor Author

hmm. This was passing locally. Will get it working here before review is needed.

@mohammadfawaz mohammadfawaz added the The Sway Book Everything to do with the Sway Book label Mar 17, 2022
@nfurfaro nfurfaro requested a review from mohammadfawaz March 18, 2022 15:22
mohammadfawaz
mohammadfawaz approved these changes Mar 18, 2022
View reviewed changes
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@nfurfaro nfurfaro merged commit 3f93eba into master Mar 18, 2022
@nfurfaro nfurfaro deleted the furnic/docs-while-loops branch March 18, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadfawaz mohammadfawaz mohammadfawaz approved these changes

Assignees

@nfurfaro nfurfaro

Labels
testing General testing The Sway Book Everything to do with the Sway Book
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document loops and add some E2E tests
2 participants
@nfurfaro @mohammadfawaz