-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space out errors and warnings for readability #961
Conversation
I guess |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was the lockfile updated?
I'm not sure what exactly changed, but I just reset the lockfile and rebuilt, and it got updated again. Maybe the toml changed on |
Ah makes sense. Can you make a separate PR to update the lockfile in isolation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, can't think of a better way off the top of my head.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change would be helpful. A possible improvement might be to either:
- change the color of the
----
- use more ----'s ! ie: Each error in its own box. Not sure if that would look crowded though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, I have no major preference either way :)
I am working on #308, and I'm noticing that when a lot of errors are generated, they can be very difficult to visually differentiate.
This PR adds (somewhat primitive) visual boundaries between the errors/warnings:
I don't know if this is the best way of doing this, and I'm open to feedback and/or using an alternate separator. But I do think this improves the UX a bit.