Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Supertraits and where clauses #969

Merged
merged 22 commits into from
Mar 20, 2022
Merged

Document Supertraits and where clauses #969

merged 22 commits into from
Mar 20, 2022

Conversation

ControlCplusControlV
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV commented Mar 19, 2022

As always if my language doesn't match docs style or code examples aren't in depth enough lmk. The mention of the core library Ord isn't implemented yet but planning on getting to it, the examples don't focus on implementing other things but showing how you would, so if they need to be expanded into more real world examples I can do that

Closes #753 and #854

@mohammadfawaz mohammadfawaz added the The Sway Book Everything to do with the Sway Book label Mar 19, 2022
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! When you make the requested changes, I will review again to make sure it's all coherent :)

docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/traits.md Outdated Show resolved Hide resolved
docs/src/advanced/generic_types.md Outdated Show resolved Hide resolved
docs/src/advanced/generic_types.md Outdated Show resolved Hide resolved
docs/src/advanced/generic_types.md Outdated Show resolved Hide resolved
docs/src/advanced/generic_types.md Show resolved Hide resolved
ControlCplusControlV and others added 10 commits March 19, 2022 16:33
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
@ControlCplusControlV
Copy link
Contributor Author

Changes are added, really need to added code spell check to my nvim config

ControlCplusControlV and others added 5 commits March 19, 2022 17:32
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Co-authored-by: Mohammad Fawaz <mohammadfawaz89@gmail.com>
Copy link
Contributor

@mohammadfawaz mohammadfawaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more minor things and you're good to go!

docs/src/advanced/generic_types.md Outdated Show resolved Hide resolved
docs/src/advanced/generic_types.md Outdated Show resolved Hide resolved
@ControlCplusControlV
Copy link
Contributor Author

Changes committed (Assuming I moved the warning to the right spot)

Should note this closes both #753 and #854

@mohammadfawaz mohammadfawaz merged commit 7b51e65 into FuelLabs:master Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Sway Book Everything to do with the Sway Book
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Document that supertraits are WIP in the where clause examples in the book
2 participants