Error reporting improvements and a few other changes

.eslintrc.js

@@ -9,18 +9,17 @@ module.exports = {
   },
   extends: [
     '@fuelrats/eslint-config',
-    '@fuelrats/eslint-config/plugins/fuelrats',
     '@fuelrats/eslint-config-react',
+    'plugin:@next/next/recommended',
   ],
   rules: {
     'jsx-a11y/no-noninteractive-element-interactions': ['off'], // We intend to enable this once we refactor certain key components.
     'jsdoc/require-jsdoc': ['off'], // we'll get to it someday...
-    'react/jsx-uses-react': ['off'],
-    'react/react-in-jsx-scope': ['off'],
     'import/order': ['error', {
       ...importRules.rules['import/order'][1],
       'newlines-between': 'always',
     }],
+    '@next/next/link-passhref': ['off'], // This rule is broken so just ignore it for now.
   },
   settings: {
     'import/ignore': [
@@ -38,11 +37,25 @@ module.exports = {
   },
   overrides: [
     {
-      files: ['src/pages/api/**/*.js'],
+      files: ['src/pages/api/**/*.js', 'src/server/**/*.mjs'],
       env: {
         browser: false,
         node: true,
       },
     },
+    {
+      files: ['*.worker.js'],
+      env: {
+        browser: false,
+        commonjs: false,
+        worker: true,
+      },
+    },
+    {
+      files: ['src/pages/**/*.js'],
+      rules: {
+        '@fuelrats/default-export-matches-module-name': ['off'], // Disabled in pages dir as it becomes difficult to stick to module names
+      },
+    },
   ],
 }

.vscode/launch.json

@@ -12,7 +12,15 @@
     },
     {
       "name": "Next: Attach Chrome",
-      "type": "chrome",
+      "type": "pwa-chrome",
+      "request": "attach",
+      "port": 9222,
+      "url": "${config:develop.attachurl}",
+      "webRoot": "${workspaceFolder}"
+    }
+    {
+      "name": "Next: Attach Edge",
+      "type": "pwa-msedge",
       "request": "attach",
       "port": 9222,
       "url": "${config:develop.attachurl}",
@@ -21,8 +29,12 @@
   ],
   "compounds": [
     {
-      "name": "Next: Attach",
+      "name": "Next: Attach All",
       "configurations": ["Next: Attach Server", "Next: Attach Chrome"]
+    },
+    {
+      "name": "Next: Attach All (Edge)",
+      "configurations": ["Next: Attach Server", "Next: Attach Edge"]
     }
   ]
 }

CHANGELOG.md

@@ -12,16 +12,25 @@ For detailed rules of this file, see  [Changelog Rules](#changelog-rules)
 *
 
 ### ⚡ Changed
-*
+* Error readout for unknown API Errors has been improved. - [#328][]
+* Reworded `Owns Odyssey` to `Using Odyssey` on rat cards to better convey the toggle's meaning. - [#328][]
+* Canceled donations will now return you to the donation form. - [#328][]
+* Optimized image loading and accessibility for images site-wide. - [#328][]
+* Further optimized font loading. - [#328][]
+* Moved raw version information to an API route (`/api/version`), and reworked version page to draw information from that route. - [#328][]
+* Other smaller changes to sreamline development. - [#328][]
 
-### 🐛 Fixed
-*
 
+### 🐛 Fixed
+* Resolved form submitting issues that occured when password evaluation fails to load. - [#328][]
+* Fixed authorization page displaying an `Invalid Authorize Request` error when redirecting users after login. - [#328][]
 
 ### ⚙ Tasks
-*
+* Update lint configs
+* Add `@next/eslint-plugin-next` into linting config.
 
 
+[#328]: https://github.com/fuelRats/fuelrats.com/pull/328
 [Unreleased]: https://github.com/FuelRats/fuelrats.com/compare/v2.13.0...HEAD
 
 

next.config.js

@@ -4,6 +4,7 @@
 /* eslint-env node */
 const crypto = require('crypto')
 const path = require('path')
+const url = require('url')
 const { DefinePlugin } = require('webpack')
 
 
@@ -12,7 +13,8 @@ const { DefinePlugin } = require('webpack')
 
 // Constants
 const {
-  APP_URL,
+  PORT = 3000,
+  APP_URL = `https://localhost:${PORT}`,
   FR_API_URL,
   FR_CLIENT_IRC_URL,
   FR_RAT_IRC_URL,
@@ -41,19 +43,26 @@ module.exports = {
   distDir: path.join('dist', 'next'),
   generateBuildId,
   images: {
-    domains: ['static-cdn.jtvnw.net'],
+    disableStaticImages: true,
+    domains: [
+      url.parse(APP_URL).hostname, // Ensure the public hostname is always allowed.
+      'wordpress.fuelrats.com',
+      'static-cdn.jtvnw.net',
+    ],
+  },
+  eslint: {
+    // Ignore ESLint in builds as our CI Takes care of this for us.
+    ignoreDuringBuilds: true,
   },
   publicRuntimeConfig: {
-    local: {
-      publicUrl: APP_URL,
-    },
+    appUrl: APP_URL,
     irc: {
       client: FR_CLIENT_IRC_URL ?? 'https://qms.fuelrats.dev',
       rat: FR_RAT_IRC_URL ?? 'https://kiwi.fuelrats.com',
     },
     apis: {
       fuelRats: {
-        local: `${APP_URL}/api/fr`,
+        url: `${APP_URL}/api/fr`,
         server: FR_API_URL ?? 'https://dev.api.fuelrats.com',
         socket: FR_SOCKET_URL ?? 'wss://dev.api.fuelrats.com',
       },
@@ -66,8 +75,60 @@ module.exports = {
       },
     },
   },
-  future: {
-    webpack5: true,
+  redirects: () => {
+    return [
+      {
+        // Temporary workaround so canceled donations return to donate screen
+        source: '/donate/cancel',
+        destination: '/donate',
+        permanent: false,
+      },
+      {
+        // Profile page requires a tab name in the path
+        source: '/profile',
+        destination: '/profile/overview',
+        permanent: true,
+      },
+      {
+        // Old blog used to exist at /blogs
+        source: '/blogs',
+        destination: '/blog',
+        permanent: true,
+      },
+      {
+        // get-help was used at launch of the website, but has since been changed back.
+        source: '/get-help',
+        destination: '/i-need-fuel',
+        permanent: true,
+      },
+      {
+        // Common endpoint for privacy policies
+        source: '/privacy',
+        destination: '/privacy-policy',
+        permanent: true,
+      },
+      {
+        // Lexicon is no longer local
+        source: '/fuel-rats-lexicon',
+        destination: 'https://confluence.fuelrats.com/pages/viewpage.action?pageId=3637257',
+        permanent: true,
+        basePath: false,
+      },
+      {
+        // statistics are no longer local
+        source: '/statistics',
+        destination: 'https://grafana.fuelrats.com',
+        permanent: true,
+        basePath: false,
+      },
+      {
+        // People often type this one manually into their URL bar to get to the helpdesk
+        source: '/help',
+        destination: 'https://t.fuelr.at/help',
+        permanent: true,
+        basePath: false,
+      },
+    ]
   },
   webpack: (config, opt) => {
     /* Define Plugin */
@@ -86,11 +147,6 @@ module.exports = {
     // Workaround to fix dev warning: https://github.com/vercel/next.js/issues/19865
     config.output.hotUpdateMainFilename = 'static/webpack/[fullhash].[runtime].hot-update.json'
 
-    // Workaround to fix production builds with workers: https://github.com/vercel/next.js/issues/22813
-    config.output.chunkFilename = opt.isServer
-      ? `${opt.dev ? '[name]' : '[name].[fullhash]'}.js`
-      : `static/chunks/${opt.dev ? '[name]' : '[name].[fullhash]'}.js`
-
     /* SVGR */
     config.module.rules.push({
       exclude: /node_modules/u,