Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#362] Remove connect() #366

Merged
merged 57 commits into from
Jul 26, 2021
Merged

[#362] Remove connect() #366

merged 57 commits into from
Jul 26, 2021

Conversation

UncleClapton
Copy link
Member

@UncleClapton UncleClapton commented Jul 26, 2021

Closes #362

Changelog

⚡ Changes

  • Numerous components have been rewritten as functional hook components instead of classes.
  • Replaced remaining usages of the old connect() HoC with a hook-friendly tree-shakable solution

🐛 Fixes

  • CSP rules have been fixed

⚙️ Tasks

  • Upgrade to node 16 to bring us in line with the upcoming API release.

Additional Information

This is a HUGE change, and a step forward towards slimming redux boilerplate or outright replacing redux.

Contributor's Checklist

  • This PR was created to resolve an existing issue or set of issues.
  • This PR satisfies any and all acceptance criteria laid out by issue(s) it resolves.
  • I have discussed creating this PR with the maintainers in the issue(s) beforehand.
  • I have thoroughly tested the changes this PR introduces in a local development environment.
  • I have linted the entire codebase using yarn lint and confirmed there are no errors or warnings.
  • I have followed the commit conventions laid out by CONTRIBUTING.md.

Maintainer's Checklist

  • User-facing changes this PR introduces have been or will be documented in CHANGELOG.md.
  • This PR has been linted and tested locally as a part of the review process.
  • All issues this PR resolves have been properly linked before merging.

This is a total edge case since all users should have at least 1 rat, but JUST IN CASE
@UncleClapton UncleClapton changed the title Refactor/remove connect hoc [#362] Remove connect() Jul 26, 2021
@UncleClapton UncleClapton merged commit 805de19 into develop Jul 26, 2021
@UncleClapton UncleClapton deleted the refactor/remove-connect-hoc branch July 26, 2021 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocker: Removing remaining usages of the custom connect() hoc
1 participant