-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warnings to I-Need-Fuel page for users on unsupported devices (… #371
Added warnings to I-Need-Fuel page for users on unsupported devices (… #371
Conversation
…Mobile & Xbox). Co-authored-by: Cameron Welter <UncleClapton@users.noreply.github.com>
src/pages/i-need-fuel.js
Outdated
message: ` | ||
It appears you're connecting from a mobile device. | ||
Ensure your device's screen and browser remains active through the course of your rescue. | ||
You may loose connection otherwise! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Lose connection", not loose. Also "throughout your rescue" is probably better language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why I shouldn't write things while tired AF
src/pages/i-need-fuel.js
Outdated
Xbox: { | ||
type: 'warn', | ||
message: ` | ||
It appears you're connecting from a mobile device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably read something like
It appears you're connecting from your Xbox!
While you may use the Xbox browser to use our services, we recommend using your computer to ensure a consistent connection.
<:bug::sparkles:> Implemented new logic for dealing with different devices
Added the ability to dynamically show errors or warnings depending on the device the user is accessing the website from.
PlayStation: Error
Xbox: Warning
Mobile (and anything else not web): Warning
Co-authored-by: Cameron Welter UncleClapton@users.noreply.github.com
Closes #354
Changelog
✨ Additions
ua-parser-js
⚡ Changes
I-Need-Fuel
to accommodate for different types of errors and warnings depending on the user's device. We now usesession.userAgent
for the constructor ofua-parser-js
to detect the user's device.🔥 Removals
🐛 Fixes
⚙ Tasks
Additional Information
Contributor's Checklist
yarn lint
and confirmed there are no errors or warnings.CONTRIBUTING.md
.Maintainer's Checklist
CHANGELOG.md
.