Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/carousel loading weirdness #372

Merged
merged 6 commits into from
Sep 8, 2021
Merged

Conversation

UncleClapton
Copy link
Member

Closes #367

Changelog

πŸ› Fixes

  • The front-page image carousel no longer goes haywire during first pageload

βš™ Tasks

  • Upgrade to Next v11.1.2
  • Update babel config file

Contributor's Checklist

  • This PR was created to resolve an existing issue or set of issues.
  • This PR satisfies any and all acceptance criteria laid out by issue(s) it resolves.
  • I have discussed creating this PR with the maintainers in the issue(s) beforehand.
  • I have thoroughly tested the changes this PR introduces in a local development environment.
  • I have linted the entire codebase using yarn lint and confirmed there are no errors or warnings.
  • I have followed the commit conventions laid out by CONTRIBUTING.md.

Maintainer's Checklist

  • User-facing changes this PR introduces has been or will be documented in CHANGELOG.md.
  • This PR has been linted and tested locally as a part of the review process.
  • All issues this PR resolves have been properly linked before merging.

@UncleClapton UncleClapton added Type | Bug πŸ› An issue or PR that describes or fixes a problem with existing code Type | Dependencies πŸ”Œ A PR that updates an outdated dependency labels Sep 8, 2021
@UncleClapton UncleClapton self-assigned this Sep 8, 2021
@UncleClapton UncleClapton added this to the v2.14.0 milestone Sep 8, 2021
@UncleClapton UncleClapton merged commit d6e2085 into develop Sep 8, 2021
@UncleClapton UncleClapton deleted the fix/carousel-loading-weirdness branch September 8, 2021 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type | Bug πŸ› An issue or PR that describes or fixes a problem with existing code Type | Dependencies πŸ”Œ A PR that updates an outdated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Font page Carousel gets images multiple times
1 participant