#127 further improvements

common/game/mode/fugitive/FugitiveGame.gd

@@ -114,12 +114,12 @@ func spawn_player(playerId: int, hiderSpawns: Array, seekerSpawns: Array):
 	var localPlayerId := get_tree().get_network_unique_id()
 	var localPlayerType: int
 	if GameData.players.has(localPlayerId):
-		localPlayerType = GameData.players[localPlayerId].get_type()
+		localPlayerType = GameData.get_player(localPlayerId).get_type()
 	else:
 		localPlayerType = FugitiveTeamResolver.PlayerType.Unset
 
 	# Extract the player data
-	var player := GameData.players[playerId] as PlayerData
+	var player := GameData.get_player(playerId)
 	var playerName := player.get_name()
 	var playerType := player.get_type()
 

common/lobby/Lobby.gd

@@ -40,7 +40,7 @@ func create_player(playerId: int):
 
 	print("Creating player in lobby")
 
-	var player := GameData.players[playerId] as PlayerData
+	var player := GameData.get_player(playerId)
 	var mode = Maps.get_mode_for_map(GameData.general[GameData.GENERAL_MAP])
 
 	var playerListItem = preload("res://common/lobby/PlayerListItem.tscn")
@@ -76,7 +76,7 @@ func remove_player(playerId: int):
 
 
 func repopulate_player(playerId: int):
-	var player := GameData.players[playerId] as PlayerData
+	var player := GameData.get_player(playerId)
 	var mode = Maps.get_mode_for_map(GameData.general[GameData.GENERAL_MAP])
 
 	var node := find_player_node(playerId)

networking/ServerNetwork.gd

@@ -55,7 +55,7 @@ remote func on_register_self(playerId: int, playerName: String, gameVersion: int
 	# Catch the new player up on who is already here
 	for curPlayerId in GameData.players:
 		if curPlayerId != playerId:
-			var player = GameData.players[curPlayerId]
+			var player := GameData.get_player(curPlayerId)
 			ClientNetwork.register_player(playerId, player)
 
 	ClientNetwork.update_game_data()