Allow custom XGBoost versions in XGBOOST_BUILD_VERSION #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrabodhaSrimal
requested review from
andyferris,
draffelt,
greghislop,
msbahal and
yilun
PrabodhaSrimal
force-pushed
the
fix-xgboost-build-failure
branch
2 times, most recently
from
51f8b65 to
ba994bc
Compare
Currently XGBoost.jl allow building either "master" or known stable tags of XGBoost git repository. This change removes that restriction and make it possible to build any tagged version, branch or git commitsh. This is required to workaround some of XGBoost.jl package build issues.
PrabodhaSrimal
force-pushed
the
fix-xgboost-build-failure
branch
from
ba994bc to
42461d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently XGBoost.jl allow building either "master" or known stable tags (v0.6, v0.8) of XGBoost git repository. This change removes that restriction and make it possible to build with any git tag, branch or commitsh.
This is required to workaround some of XGBoost.jl package build issues occurred due to some refactoring done in XGBoost git repository
With this change we can build XGBoost.jl with last known good git commit of XGBoost.