-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Upgrading from 5 to 6: illegal operation on a directory #1266
Labels
Comments
aminya
added a commit
to aminya/purgecss
that referenced
this issue
Dec 15, 2024
This fixes the glob regression issues from v5 + parallelizes the async IO operations for faster purge. ## Proposed changes Fixes an issue that the previously working glob expressions no longer work in v6 and v7. This changes the glob dependency to fast-glob to fix the issue. I also parallelized the async-io operations for faster purge. Fixes FullHuman#1266 ## Types of changes What types of changes does your code introduce? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] Lint and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments
aminya
added a commit
to aminya/purgecss
that referenced
this issue
Dec 15, 2024
This fixes the glob regression issues from v5 + parallelizes the async IO operations for faster purge. ## Proposed changes Fixes an issue that the previously working glob expressions no longer work in v6 and v7. This changes the glob dependency to fast-glob to fix the issue. I also parallelized the async-io operations for faster purge. Fixes FullHuman#1266 ## Types of changes What types of changes does your code introduce? _Put an `x` in the boxes that apply_ - [x] Bugfix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) ## Checklist _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._ - [x] Lint and unit tests pass locally with my changes - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added necessary documentation (if appropriate) ## Further comments
6 tasks
I made a pull request in #1308 and verified that the issue is now fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I upgraded from purgecss 5 to 6, but I have started to get these errors. Not sure where they come from. Seems to be related to glob.
To Reproduce
The
purgecss.config.ts
The script
Environment
Node 22, Linux
Add any other context about the problem here
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: