Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: vinyl-sourcemaps-apply should not be in dev deps (for gulp-purgecss) #999

Closed
1 task done
j0k3r opened this issue Sep 20, 2022 · 0 comments
Closed
1 task done

Comments

@j0k3r
Copy link
Contributor

j0k3r commented Sep 20, 2022

Describe the bug

While upgrading from 4.1.3 to 5.0.0, we got an error during the process:

$ gulp
[11:06:05] Requiring external module ts-node/register
Error: Cannot find module 'vinyl-sourcemaps-apply'
Require stack:
- /home/travis/build/20minutes/hela/node_modules/gulp-purgecss/lib/gulp-purgecss.js
- /home/travis/build/20minutes/hela/scripts/buildCssPageType.ts
- /home/travis/build/20minutes/hela/gulpfile.ts

That new deps used in index.ts might move to direct deps instead of dev deps:
image

To Reproduce

I guess just upgrading an existing project using gulp-purgecss from v4 to v5

Expected Behavior

No error throw about the missing package.

Environment

  • MacOS but the problem appear on Travis too.
  • Node 16

Add any other context about the problem here

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants