Skip to content

Conversation

@julien-deramond
Copy link

@julien-deramond julien-deramond commented Apr 25, 2025

Proposed changes

This PR proposes two minor documentation updates to reflect recent changes regarding the use of purgeCSSPlugin. Additionally, it addresses any potential oversights where purgecss was still referenced instead of purgeCSSPlugin.

The modification to docs/getting-started.md appeared straightforward, especially when compared to similar changes we've made in the past. Specifically, we're not utilizing the imported item in this case.

For the update to packages/postcss-purgecss/README.md, I tested the approach locally. However, since I'm not an advanced user of PurgeCSS, there may be nuances I've missed, so I'm open to feedback on this part.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Documentation fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes

    • Note: there was a linting issue but apparently not linked to my modifications since I replicate in the mainbranch
    /Users/ju/purgecss/docs/.vuepress/.cache/deps/@vue_devtools-api.js
    3901:5  error  Definition for rule 'es5/no-es6-methods' was not found  es5/no-es6-methods
  • (N/A) I have added tests that prove my fix is effective or that my feature works

  • I have added necessary documentation (if appropriate)

Further comments

N/A

@julien-deramond julien-deramond marked this pull request as ready for review April 25, 2025 07:14
@github-actions
Copy link

This PR is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Oct 23, 2025
@github-actions github-actions bot closed this Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant