Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the CLI output valid JSON #176

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Ensure that the CLI output valid JSON #176

merged 1 commit into from
Apr 5, 2019

Conversation

Mayeu
Copy link
Contributor

@Mayeu Mayeu commented Mar 27, 2019

Proposed changes

This commit ensure that the CLI output valid JSON on stdout, so that it could then be manipulated in the shell using jq or other JSON manipulation tool.

Previously the output was not JSON valid making it hard to reuse.

I am also open to contribute an additional flag instead of making it the default.

Types of changes

What types of changes does your code introduce to Purgecss?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

This commit ensure that the CLI output valid JSON on stdout, so that it could then be manipulated in the shell using jq or other JSON manipulation tool.

Previously the output was not JSON valid making it hard to reuse.
@Ffloriel
Copy link
Member

Ffloriel commented Apr 5, 2019

Thanks for the PR :)

@Ffloriel Ffloriel merged commit ac5a55c into FullHuman:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants