Skip to content

Feat/svgr transform #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Feat/svgr transform #6

wants to merge 5 commits into from

Conversation

Moro-Code
Copy link
Collaborator

Add a transformation to change .svg imports to use svgr components

@Moro-Code Moro-Code requested a review from charle692 January 3, 2024 20:43
Copy link
Collaborator

@charle692 charle692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good to go with this :) awesome job. I just left 3 optional comments about the return false; statement not being required.

node.source.value = source.replace("?url", "");
}

return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You technically don't need these return false. It was left over in a older transform before I made some other changes.

});
}

return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

}
}

return false;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants