Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superflat generation bug prevents one from entering the world #12

Closed
Alluysl opened this issue Aug 4, 2021 · 1 comment
Closed

Superflat generation bug prevents one from entering the world #12

Alluysl opened this issue Aug 4, 2021 · 1 comment
Assignees

Comments

@Alluysl
Copy link

Alluysl commented Aug 4, 2021

Versions
Minecraft: 1.17.1
Fabric loader: didn't ask the person, doesn't matter either way
Fabric API: 0.37.1
Companion Bats: 1.17.4
No other mods used

Modloader
Fabric

Describe the bug
Loading/creating an existing/new superflat world with the mod results in an error that prevents the world from being entered.

To Reproduce
Steps to reproduce the behavior:

  1. Create new superflat world
  2. You're greeted with an invalid datapacks error and an error in the logs (caused by trying to access the feature field of a ConfiguredStructureFeature which is null)
  3. Choosing safe mode sends you back to the same screen

Expected behavior
The world loads properly as in vanilla, potentially with the feature

Cause
The Cave House is improperly registered in superflat worlds.

Possible fix
Superflat worlds require additional registry according to this issue, either disable the feature there or perform said registry.
This is the commit that fixed the issue in that mod, but I'm unaware if applying the same fix is possible or enough for features, though I just took a look at your initializer class and it seems pretty likely that it would work.

@Alluysl Alluysl changed the title Superflat generation bug prevents the world from loading in Superflat generation bug prevents one from entering the world Aug 4, 2021
helpimnotdrowning added a commit to helpimnotdrowning/CompanionBats that referenced this issue Aug 5, 2021
Fulmineo64 added a commit that referenced this issue Aug 8, 2021
@Fulmineo64
Copy link
Owner

Hi Alluysl,
thank you for opening the issue.

As you can see helpimnotdrowning fixed it in a second!

You can find the fix in the latest release.

Many thanks to both of you for making the Companion Bats mod better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants