-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interactive standalone keystone mode #54
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunNova
reviewed
Dec 11, 2024
LunNova
reviewed
Dec 11, 2024
LunNova
reviewed
Dec 11, 2024
LunNova
reviewed
Dec 11, 2024
436f4b0
to
4c9cfec
Compare
LunNova
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This still does not allow installing keystone as a service, so it must be run under a session. You can do this via
cargo run
via the following:the actual command here is:
Keystone will still run without
-i
but it won't be interactive.-i
provides the interactive TUI that lets you manage the modules you spawned.Keystone is still using stdin/stdout for RPC communication, which will be addressed in a separate PR. This PR contains necessary refactors to make it possible to fix that.