Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add manifold and keep aleph in dev dependencies #360

Merged
merged 1 commit into from
Dec 5, 2023
Merged

add manifold and keep aleph in dev dependencies #360

merged 1 commit into from
Dec 5, 2023

Conversation

AndreaCrotti
Copy link
Contributor

@AndreaCrotti AndreaCrotti commented Apr 28, 2023 •
edited
Loading

Checklist

  • tests
  • updated CHANGELOG (the "unreleased" section)

@AndreaCrotti AndreaCrotti mentioned this pull request Apr 28, 2023
Open
@AndreaCrotti
Copy link
Contributor Author

I think maybe the only problem would be that people using the test-machine would just need to add the aleph dependency in their own project, but I think if that's just mentioned in the README it should not be an issue.

@AndreaCrotti AndreaCrotti marked this pull request as ready for review May 10, 2023 14:49
@AndreaCrotti AndreaCrotti requested a review from a team as a code owner May 10, 2023 14:49
@minimal minimal merged commit 187a871 into FundingCircle:master Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimal minimal minimal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreaCrotti @minimal