-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/automatic-offset-flipping] change offset fix properties #3543
base: feature/automatic-offset-flipping
Are you sure you want to change the base?
[feature/automatic-offset-flipping] change offset fix properties #3543
Conversation
7679e4d
to
3069396
Compare
Base branch has been updated to include working submodules. Also, your changes do NOT fix Tankman's flipped animations regardless of configuration. The feature needs to work on any characters whose offsets are correct right now, otherwise it will create a bunch of work for us (manually reconfiguring offsets) as well as a bunch of work for mod creators (who will have to fix their character offsets). Try testing characters where |
i took some notes
whether the offsets are intended for the player or opponent side is arbitrary and this affects when the offsets should be flipped, so im rewriting the properties to reflect that see updated pr description |
Briefly describe the issue(s) fixed.
fixes some logic issues with the offset flip fix for #3539 by changing up some properties, as well as adding rotation support
character versions
<1.1.0
are unaffectedautoCorrectAnimations
allowsflipXOffsets
andflipYOffsets
as well as rotation compensation to workflipXOffsets
andflipYOffsets
are now arbitrary (unless a character, see below)playerSideOffsets
determines whetherflipXOffsets
is true or notplayerSideSingAnimations
determines whetherflipSingAnimations
is true or not2024-10-03.18-40-46.mp4
2024-10-03.18-41-51.mp4
2024-10-03.18-51-37.mp4
in these examples: