Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Cap Score Displays to their biggest possible values #3634

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JustKolosaki
Copy link
Contributor

@JustKolosaki JustKolosaki commented Oct 10, 2024

Does this PR close any issues? If so, link them below.

3631

Briefly describe the issue(s) fixed.

No, this does not cap the score itself as well. Just wanted to clarify that.
Caps the score displays in ResultState and FreeplayState to their maximum possible value. Adding more numbers instead would just make it look ugly and yucky :[

(this is not as massive of a change as it shows lol it makes it look like the automatically made spaces from vscode settings are one of the changes lol)

@github-actions github-actions bot added haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes labels Oct 10, 2024
@Hundrec
Copy link
Contributor

Hundrec commented Oct 10, 2024

mmyes
Thank you for preventing another crash!

@JustKolosaki
Copy link
Contributor Author

mmyes Thank you for preventing another crash!

anytime

@Shaunyman
Copy link

The people deserve to have their hundred-million scores displayed! Lol, I'm just messing around. While I would like that to be the case, I'm honestly just glad somebody looked into the issue. If both the freeplay score and the results screen score were capped to 9,999,999, that would fix the crash that happens when trying to select the chart difficulty again, right? Because that's really the biggest issue in my humble opinion.

@JustKolosaki
Copy link
Contributor Author

The people deserve to have their hundred-million scores displayed! Lol, I'm just messing around. While I would like that to be the case, I'm honestly just glad somebody looked into the issue. If both the freeplay score and the results screen score were capped to 9,999,999, that would fix the crash that happens when trying to select the chart difficulty again, right? Because that's really the biggest issue in my humble opinion.

Yup, that should be why the crash happens - the game tries to reference a null object when the score is over the cap. ResultState is in a similar boat

@JustKolosaki JustKolosaki changed the title [FIX] Cap score display to 9,999,999 [FIX] Cap Score Displays to their biggest possible values Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haxe Issue/PR modifies game code medium A medium pull request with 100 or fewer changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants