Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes _index from cocos params, improves & fixes docs, raises when cannot det. single cocos or no qpsi present #18

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Removes _index from cocos params, improves & fixes docs, raises when cannot det. single cocos or no qpsi present #18

merged 3 commits into from
Jul 10, 2024

Conversation

oliverfunk
Copy link
Contributor

No description provided.

@oliverfunk
docs and removal of _index and change to the way identify works, it r…
767be51 
…aises if it cannot find a single convention and qpsi must be provided
@oliverfunk oliverfunk requested a review from a team as a code owner July 4, 2024 13:54
je-cook
je-cook requested changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably detect the eqdsks correctly inc the ones in private data. I think they're either 3, 7 or 11 no 17s

eqdsk/file.py Outdated Show resolved Hide resolved
tests/test_file.py Outdated Show resolved Hide resolved
tests/test_file.py Outdated Show resolved Hide resolved
tests/test_file.py Outdated Show resolved Hide resolved
tests/test_file.py Outdated Show resolved Hide resolved
@oliverfunk oliverfunk changed the title Docs and raising on qpsi or no single convention being identifiable Removes _index from cocos params, improves & fixes docs, raises when cannot det. single cocos or no qpsi present Jul 9, 2024
je-cook
je-cook approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@je-cook je-cook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how if you provide 0 data it treats it as unset. We should make sure that is in the docs when we build them!

@je-cook je-cook merged commit 19b457e into main Jul 10, 2024
2 checks passed
@je-cook je-cook deleted the oliverfunk/docs branch July 10, 2024 08:07
@je-cook je-cook added the enhancement New feature or request label Jul 10, 2024
OceanNuclear
OceanNuclear approved these changes Jul 10, 2024
View reviewed changes
Copy link

@OceanNuclear OceanNuclear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, looks like it's just changing to COCOS convention 3/11 isn't it

oliverfunk added a commit that referenced this pull request Jul 10, 2024
@oliverfunk
Removes _index from cocos params, improves & fixes docs, raises when …
f959f7e 
…cannot det. single cocos or no qpsi present (#18)

* docs and removal of _index and change to the way identify works, it raises if it cannot find a single convention and qpsi must be provided

* improved error message for improper id'ing

* improved error messages, fixed tests, added negative qpsi for all bluemira generated eqdsks
oliverfunk added a commit that referenced this pull request Jul 10, 2024
@oliverfunk
Removes _index from cocos params, improves & fixes docs, raises when …
c3106c2 
…cannot det. single cocos or no qpsi present (#18)

* docs and removal of _index and change to the way identify works, it raises if it cannot find a single convention and qpsi must be provided

* improved error message for improper id'ing

* improved error messages, fixed tests, added negative qpsi for all bluemira generated eqdsks
oliverfunk added a commit that referenced this pull request Jul 10, 2024
@oliverfunk
Removes _index from cocos params, improves & fixes docs, raises when …
8b8a9ee 
…cannot det. single cocos or no qpsi present (#18)

* docs and removal of _index and change to the way identify works, it raises if it cannot find a single convention and qpsi must be provided

* improved error message for improper id'ing

* improved error messages, fixed tests, added negative qpsi for all bluemira generated eqdsks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@je-cook je-cook je-cook approved these changes

@OceanNuclear OceanNuclear OceanNuclear approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverfunk @OceanNuclear @je-cook