Release/1.53.0 #3252
Merged
Release/1.53.0 #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add webhookEventLogConfiguration to system config * document webhook_event_log_viewer role * doc for retrieving webhook event log APIs * document webhook event log admin UI
* add doc for new loginIntent TTL * add doc for fusionauth.li cookie
* java 21 note * wording
…e into release/1.53.0
spwitt
previously approved these changes
Sep 5, 2024
2. Add missing Docker image removal. 3. Move new lambda function from Changed to New. 4. Move new action buttons from Changed to Enhancements. Changed should be reserved for things that will potentially affect integrations. 5. Normalize "Update dependencies." and "Update 3rd party dependencies." 6. Expand upon the potential impact to the connection pool changes. 7. Correct formatting in release notes for 1.50.0. 8. Use the correct form of BreadCrumbs.
…not document `null`, instead we should indicate when a field will be omitted from the response. 2. Be more consistent with the definition of the Id. 3. Delete dead imports (EventTypes and InlineField) in _webhook-attempt-log-response-body-base.mdx.
2. Don't mention the LoginLambdaValidationContext, this is an internal object. 3. context is read only. 4. Mention when identityProvider is found in the context. 5. Fix broken link to error doc. 6. Don't use fully qualified URLS to docs, use relative links. 7. Remove trailing comma on JSON example 7. Discuss localization.
- Rename LambdaTypeApi -> LambdaTypeAPI - Describe the behavior differences in optional messages for themes in 1.53.0.
mooreds
reviewed
Sep 6, 2024
astro/src/content/docs/extend/code/lambdas/login-validation.mdx
Outdated
Show resolved
Hide resolved
…e into release/1.53.0
Co-authored-by: Dan Moore <dan@fusionauth.io>
| --- | ||
| { since && <span class="pl-3 text-red-700 italic">Deprecated since {since}</span> } | ||
| { since && hasContent && <span class="text-red-700 italic">Deprecated since {since}</span> <div class="prose-p:mt-1"><slot></slot></div> } |
There was a problem hiding this comment.
Why are we adding a slot here? The rest of these components just specifically format a single value and are not structural. Probably need those class-like components in their own directory to differentiate them from the others here.
… DeprecatedSince - Remove old system config reference - Remove dead imports
| @@ -1,8 +1,20 @@ | |||
| --- | |||
| interface Props { | |||
| since: string; | |||
| inline: boolean, | |||
There was a problem hiding this comment.
this field looks optional based on how it is used
| const { inline, since }: Props = Astro.props; | ||
| const hasContent = Astro.slots.has("default"); | ||
| let classList = 'text-red-700 italic'; | ||
| if (inline) { |
There was a problem hiding this comment.
This is confusing to me. The span is inline by default, it looks like what you are going for is just to minimize the margin between the next line of text. I don't think we need a new div for that. Or is this meant to actually encapsulate the content in a meaningful way? Should it be an aside?
robotdan
previously approved these changes
Sep 6, 2024
robotdan
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes and user docs for 1.53.0.