Remove inline prop, move lambda type back into the correct locations. #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
robotdan
commented
Sep 9, 2024
robotdan
commented
- Remove inline prop, recently added, discussed with Lyle.
- Move lambda type back into the request body and response respectively.
lyleschemmerling
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
this makes sense. Observation: every time you used an "inline" was either inside of an li or a td element. Should be able to do some css magic to accomodate encapsulating all of the text that is version-specific. However, I wasn't quite able to make Tailwind to do this when I was playing with it.
This may be the straw that breaks the camel and I decide to go CSS for the markdown stylings, but that is for Future Lyle to figure out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.