Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rearrange the intro some #3383

Merged
merged 5 commits into from
Nov 19, 2024
Merged

Conversation

lyleschemmerling
Copy link
Contributor

@lyleschemmerling lyleschemmerling commented Nov 12, 2024

Update: Here is what I have it looking like now:

image

This will look slightly better if we can come up with a better piece of text for the "title" of the page, to match what Articles look like. So if we can come up with a better title we can change what it is in the index file and it will look like this

Screenshot 2024-11-19 at 11 27 33 AM

@SeanBobby
Copy link
Contributor

Yeah, this doesn't work. It seems to bloat the page and the icon/asset looks completely off. Additionally - And I know we've covered this in the past, Quickstarts twice on the upper left of the page is not a good aesthetic. Let's review in our call tomorrow.

@mooreds
Copy link
Contributor

mooreds commented Nov 15, 2024

Hey folks what is the status of this? Would love to get this helpful text live.

@mooreds
Copy link
Contributor

mooreds commented Nov 18, 2024

Another option would be to remove the image entirely.

const image = "/img/icons/quickstart.svg";

const title = 'Quickstarts';
const section = ''; // Change this to "Quickstarts" if you want to give the index page a different title;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is where we can change what title and "section" are in the top of the page

mooreds
mooreds previously approved these changes Nov 19, 2024
Copy link
Contributor

@mooreds mooreds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled it down, it fixes the previous mobile issue and has all that text that I lovingly crafted.

:shipit:

…e/WRQ-40/quickstarts-header

# Conflicts:
#	astro/src/pages/docs/quickstarts/index.astro
@lyleschemmerling lyleschemmerling merged commit c85fe78 into main Nov 19, 2024
2 of 3 checks passed
@lyleschemmerling lyleschemmerling deleted the lyle/WRQ-40/quickstarts-header branch November 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants