-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix homebrew install #20
base: develop
Are you sure you want to change the base?
Conversation
…oved in newer versions of ruby
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we delete fusionauth-search.rb
Formula?
We deprecated in Oct 2023 - I think we are only publishing the .deb
for our own use at the moment.
@robotdan I can drop the fusionauth-search build here, but there are two reasons why we may not want to:
If we don't want to worry about either of those right now I can drop search and call it a day |
@lyleschemmerling as discussed, the test was not actively using fusionauth-search instance as the search type was database. It only tested the proper installation start and stop of it. There is a opensearch homebrew installation available in case anyone needs search too. But for most e2e tests search is overkill unless very specific functionality is tested provided by search. The idea behind the test is to run the 2 latest macos github runner in a matrix workflow to check if 1. the homebrew installation is still functional after each release and 2. is working on the github provided macos runner builds. Side note, on github macos runner none of the docker implementations i tested work because its missing nested virtualization which is why homebrew for these scenarios is relevant. |
@lyleschemmerling FYI While trying to finalize the Swift SDK i discovered one more somewhat obvious issue, all the tags are basically not working (we want to do a matrix test of the last 6 months of FusionAuth versions) and if this PR is getting merged none of the previous tags will get fixed. |
exists
doesn't exist any more, butexist
exists, so switching that so that the installer won't fail.