Support multiple images #151
Conversation
dosubot
bot
added
size:M
src/aviary/message.py
Outdated
| @@ -124,16 +123,22 @@ def create_message( | |||
| cls, | |||
| role: str = DEFAULT_ROLE, | |||
| text: str | None = None, | |||
| image: np.ndarray | None = None, | |||
| images: list[np.ndarray | str] | None = None, | |||
There was a problem hiding this comment.
I'm not sure if this will break existing uses of create_message elsewhere. However, imo it's better to make this shift now while it isn't used much than in the future. It will be quite common for users to have multiple images associated with one prompt eg "what species do all the bacteria in these images belong to?". Single images can just be a list of length 1.
There was a problem hiding this comment.
I think it can have type list[np.ndarray] | np.ndarray | None. Then, we always encode it inside the function.
We can have a check like this:
if isinstance(images, str):
images = [images]
I believe this will keep compatibility with the previous behavior
This reverts commit 612be2f.
dosubot
bot
added
size:L
src/aviary/message.py
Outdated
| @@ -124,16 +123,22 @@ def create_message( | |||
| cls, | |||
| role: str = DEFAULT_ROLE, | |||
| text: str | None = None, | |||
| image: np.ndarray | None = None, | |||
| images: list[np.ndarray | str] | None = None, | |||
There was a problem hiding this comment.
I think it can have type list[np.ndarray] | np.ndarray | None. Then, we always encode it inside the function.
We can have a check like this:
if isinstance(images, str):
images = [images]
I believe this will keep compatibility with the previous behavior
pyproject.toml
Outdated
| @@ -27,6 +27,7 @@ classifiers = [ | |||
| dependencies = [ | |||
| "docstring_parser>=0.16", # Pin for description addition | |||
| "httpx", | |||
| "numpy", | |||
There was a problem hiding this comment.
Any chance we can avoid adding deps? Sorry I missed this in the original review
We should only add deps if we actually need them
No description provided.