Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LitQA and LFRQA from paper-qa #190

Merged
merged 40 commits into from
Feb 19, 2025
Merged

Migrate LitQA and LFRQA from paper-qa #190

merged 40 commits into from
Feb 19, 2025

Conversation

maykcaldas
Copy link
Collaborator

@maykcaldas maykcaldas commented Feb 13, 2025

This PR is in pair with Future-House/paper-qa#872 which removed code for LitQA and LFRQA from paper-qa

@maykcaldas maykcaldas force-pushed the implement-litqa branch 2 times, most recently from 3d6b8cf to 2ab3140 Compare February 14, 2025 22:19
@maykcaldas maykcaldas marked this pull request as ready for review February 18, 2025 02:35
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. enhancement New feature or request labels Feb 18, 2025
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close!

Will need the corresponding paper-qa PR that removes all of this stuff to just be sure for confirmation

Co-authored-by: joaquinpolonuer <jtpolonuer@gmail.com>
@JoaquinPolonuer JoaquinPolonuer changed the title Migrate LitQA from paper-qa Migrate LitQA and LFRQA from paper-qa Feb 18, 2025
Copy link
Collaborator

@jamesbraza jamesbraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, looks good. Thanks for working through everything

@maykcaldas maykcaldas merged commit 755510f into main Feb 19, 2025
8 checks passed
@maykcaldas maykcaldas deleted the implement-litqa branch February 19, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants