Disallowing confusing None
from IndexSettings.index_directory
, and IndexSettings.get_named_index_directory
#531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
None
fromIndexSettings.index_directory
was a failover to the defaultIndexSettings.index_directory
inside ofSearchIndex
. This has two issues:IndexSettings
fromSearchIndex
, which tripped me upNone
forindex_directory
could imply "no index dir" as opposed to "default index dir"Also, I implemented a convenience utility
IndexSettings.get_named_index_directory
, with a test