Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to support 1.20.4 #163

Merged
merged 1 commit into from
Jan 18, 2024
Merged

update to support 1.20.4 #163

merged 1 commit into from
Jan 18, 2024

Conversation

petersv5
Copy link
Contributor

This is an early stab at updating to 1.20.4. There are several deficiencies:

  • carpetfixes.mixins.advanced.MinecraftServer_autosaveDelayMixin needs to be rewritten to match the changes in the game

  • I do not understand what carpetfixes.mixins.reIntroduced.PlayerManager_LlamaRidingDupeMixin is trying to do with the "vmp" and "c2me" prefixes.

  • The method call intercept to com.google.commons.collect.Maps.newHashMap() fail in carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not understand why.

  • Update suppression fixes should be removed as they are handled by TIS.

The mod does compile and work for the few fixes I have tried.

This should eventually resolve #159.

This is an early stab at updating to 1.20.4. There are several
deficiencies:

- carpetfixes.mixins.advanced.MinecraftServer_autosaveDelayMixin needs
  to be rewritten to match the changes in the game

- I do not understand what
  carpetfixes.mixins.reIntroduced.PlayerManager_LlamaRidingDupeMixin
  is trying to do with the "vmp" and "c2me" prefixes.

- The method call intercept to
  com.google.commons.collect.Maps.newHashMap() fail in
  carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not
  understand why.

- Update suppression fixes should be removed as they are handled by TIS.

The mod does compile and work for the few fixes I have tried.
@FxMorin
Copy link
Owner

FxMorin commented Jan 18, 2024

Will be taking a look at this today

Copy link
Owner

@FxMorin FxMorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll probably merge this and make the rest of the changes on the branch directly

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ill be removing it, as minecraft has done significant work on it to fix lag issues.

@FxMorin
Copy link
Owner

FxMorin commented Jan 18, 2024

carpetfixes.mixins.advanced.MinecraftServer_autosaveDelayMixin needs to be rewritten to match the changes in the game

I'll be removing it.

I do not understand what carpetfixes.mixins.reIntroduced.PlayerManager_LlamaRidingDupeMixin is trying to do with the "vmp" and "c2me" prefixes.

I'll also be removing that rule. Those prefixes are for the vmp (very many people) & c2me (Concurrent Chunk Management Engine) mods. It's a compatibility fix.

The method call intercept to com.google.commons.collect.Maps.newHashMap() fail in carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not understand why.

Ya mixin always does this for google commons, not sure why. However it will still inject correctly.

@FxMorin FxMorin merged commit 1b21751 into FxMorin:dev Jan 18, 2024
1 check failed
@petersv5
Copy link
Contributor Author

The method call intercept to com.google.commons.collect.Maps.newHashMap() fail in carpetfixes.mixins.blockFixes.PistonBlock_pushOrderMixin and I do not understand why.

Ya mixin always does this for google commons, not sure why. However it will still inject correctly.

I thought I was going crazy. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to 1.20.2
2 participants