Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update push-api.json #2388

Closed
wants to merge 2 commits into from
Closed

Update push-api.json #2388

wants to merge 2 commits into from

Conversation

jpmedley
Copy link
Contributor

No description provided.

@jpmedley
Copy link
Contributor Author

@Fyrd I think there might be a bug in your Travis script. It doesn't like either of these items in my PR. I can't find anything wrong with either of them. I'f you see something I don't, I'll be happy to fix it.

"and_chr":{
"49":"a #1",
"50":"y"
},

"and_chr":{
"50":"y"
},

@@ -227,7 +227,7 @@
"35":"n"
},
"and_chr":{
"49":"a #1"
"50":"y"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the error. Only 1 version of Android Chrome is currently allowed.
See #1920 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the commit so that it only has one version. The CI check is still failing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Erm, rather, only data for what caniuse considers the "current" Android Chrome version is allowed. You'd need @Fyrd to bump that version from 49 to 50.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, can only update this once Chrome 50 for Android is out.

@Fyrd
Copy link
Owner

Fyrd commented May 4, 2016

Updated this one manually.

@Fyrd Fyrd closed this May 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants